admin/LithosAnanake
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

FABRIC.md/FABRIC-2.md: close vm_physics_retire() Hera-drop item

Browse Source 
Punch list §C item complete. Corrects this morning's "structurally
excluded" framing -- the Hera-is-root case was reachable via
S" Hera" KILL, fixed in db66406. Broken-parent-chain half remains
genuinely unreachable and is no longer tracked as open.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
Robert Allan James
2026-08-13 08:39:53 -04:00
co-authored by Claude Sonnet 5
parent db6640682b
commit 307f0e4ecc
2 changed files with 28 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
FABRIC-2.md
+23 -6
View File
@@ -121,14 +121,31 @@ and recorded.
## C. Reported bugs and dead code, not yet fixed
- [ ] **`vm_physics_retire()`'s dropped-remainder case.** (`capsule_vm_physics.c:271-275`)
- [x] **`vm_physics_retire()`'s dropped-remainder case.** (`capsule_vm_physics.c:271-275`)
If the dying VM is itself the fleet root, or its parent chain is broken, its remaining
heat has nowhere conservation-preserving to go and is zeroed instead of transferred — a
genuine, if narrow, violation of the `sum(execution_heat) == Q48_ONE` invariant. Both
triggering conditions are structurally excluded today (`capsule_vm_kill` refuses to kill
Hera; `parent_vm_id` is set once at birth and never rewritten), so this is unreachable
under current invariants, not fixed. Found while investigating the "Fleet heat leak" item
above, 2026-08-13.
genuine, if narrow, violation of the `sum(execution_heat) == Q48_ONE` invariant. Found
while investigating the "Fleet heat leak" item above, 2026-08-13.
> **CORRECTION, same day:** the "structurally excluded" framing this item originally had
> was wrong — the Hera case *was* reachable. `mama_word_kill()`
> (`mama_forth_words.c:520-530`) called `vm_physics_retire(entry.vm_id)` for any live-state
> VM found by name, with no Hera check, *before* `capsule_vm_kill()`'s own Hera guard
> (`capsule_birth.c:313-316`) ever ran. `S" Hera" KILL` therefore hit
> `vm_physics_retire()` with Hera's own id; her self-referential `parent_vm_id` made
> `vm_physics_find_root_id()` return her own id immediately, `root` came back `NULL`, and
> the fleet's entire `execution_heat_q48` sum was silently zeroed — with only the
> harmless-looking "cannot kill Hera" message as visible output, since that guard runs
> second. The broken-parent-chain half of this item remains genuinely unreachable
> (`parent_vm_id` is set once at birth and never rewritten); only the Hera half was live.
>
> **DONE 2026-08-13.** Fixed by excluding Hera from the retire call at the one call site,
> mirroring `capsule_vm_kill()`'s existing guard: `mama_forth_words.c`'s
> `capsule_vm_find_by_name_nocase(...) && entry.state == VM_STATE_LIVE` condition gained
> `&& !vm_uuid_is_hera(entry.vm_id)`. No change to `vm_physics_retire()` or
> `capsule_vm_kill()` itself. Three-arch acceptance boot, all clean to `ok>`:
> `logs/20260813-083429/amd64`, `logs/20260813-083551/aarch64`,
> `logs/20260813-083738/riscv64`. Committed `db66406`.
- [ ] `arch_mmu_init()` is declared and defined on all three architectures but never called
anywhere — dead code. Found during item 4.3.5a.
- [ ] `include/block_subsystem.h:168`'s `encoding` field (ASCII/UTF-8/binary) is dead