Robert Allan JamesandClaude Sonnet 5
b0f12710bb
Console sessions now route through the same general VM-to-VM messaging system (Phase C) any VM can already use for its own reasons -- not a synchronous shortcut. Per direct instruction: real async MSG-SEND/ MSG-DELIVER (Option B), not a VM-EXEC-based synchronous relay, because messaging is a general capability, not a console-specific mechanism. New CONSOLE-CMD-EVENT message type (common:messaging.4th). New sk_repl_dispatch_line() (repl.c), called from both sk_repl_step and sk_repl_run in place of a direct vm_interpret(): if the active VM's own name has a live "<name>~user" counterpart registered, the raw input line is wrapped as an S"-embedded CONSOLE-CMD-EVENT MSG-SEND and interpreted on the console VM instead of being run directly -- the console's own next MSG-TICK (Hera's idle pump) delivers it into the paired user VM via VM-EXEC, same mechanism every other message already uses. Falls back to direct interpretation if there's no pairing, or if the line contains a `"` (known v1 limitation, warned about explicitly rather than silently mishandled). New capsule_console_birth() (capsule_console.h/.c): a bare VM whose only content is loading common:messaging.4th -- the console side of a pairing, parallel in shape to RUNCAP's user-VM birth but with fixed embedded content instead of a devblock read (no identity, no thumbdrive involved). New PAIR-TEST diagnostic word (mama_forth_words.c, matches RUNCAP-TEST's own precedent): births both halves of a pairing and registers the "<name>~user" mapping. Not the real pairing call site -- that's the eventual attach/onboarding flow -- this exists to exercise the relay live before that flow exists. Found and fixed a real, serious bug live: console_set_vm_name() stored the caller's raw pointer instead of copying it. mama_word_use() (USE) passes a VMRegistryEntry field living on its own stack frame -- once USE returns, that pointer dangles, corrupting every console tag after the first USE (observed directly as garbled "[[]" / binary-looking prefixes instead of "[CaptBob]"). Fixed at the source: console_set_ vm_name() now copies into internal storage. That surfaced a second, related bug across every console_get_vm_name()-based save/restore call site in mama_forth_words.c (BIRTH, VM-STEP, VM-EXEC, CONNECT-HERMES, CONNECT-ARTEMIS): saving just a pointer into the single internal buffer meant an intervening console_set_vm_name() call silently corrupted the saved value before the restore ever ran. New console_save_vm_name() copies into caller-owned storage; every save/restore site updated. Verified end-to-end, live in QEMU: typed WELCOME at a paired console VM -- it did not execute directly (no UNKNOWN WORD), printed ok immediately (queued, async), and on the next idle tick "[CaptBob~user] Minted identity -- default personality" appeared on its own -- genuine delivery and execution in the paired user VM through the real MSG-SEND/MSG-DELIVER pipeline. Console tags confirmed clean (no garbling) across all three architectures' full regression boot. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019ZGkimpfyh63EZyRkNbkPD
48 lines
1.6 KiB
C
48 lines
1.6 KiB
C
/*
|
||
StarForth — Steady-State Virtual Machine Runtime
|
||
|
||
Copyright (c) 2023–2025 Robert A. James
|
||
All rights reserved.
|
||
|
||
Licensed under the StarForth License, Version 1.0
|
||
*/
|
||
|
||
/**
|
||
* capsule_console.h - Bare console-VM birth (FABRIC-3.md Phase F,
|
||
* 2026-08-28): a minimal VM whose only job is loading
|
||
* common:messaging.4th and being the physical REPL's relay target
|
||
* (sk_repl_dispatch_line(), repl.c) for a paired user VM
|
||
* (capsule_runcap_birth(), capsule_runcap.h). Not identity-bearing
|
||
* content -- no thumbdrive read, fixed embedded source, same
|
||
* heap-built-single-entry-directory shape RUNCAP already established
|
||
* (§F.6/§F.18), just with compile-time content instead of a devblock
|
||
* read.
|
||
*/
|
||
|
||
#ifndef STARKERNEL_CAPSULE_CONSOLE_H
|
||
#define STARKERNEL_CAPSULE_CONSOLE_H
|
||
|
||
#ifdef __STARKERNEL__
|
||
|
||
#include "starkernel/capsule_run.h"
|
||
#include "starkernel/vm_uuid.h"
|
||
|
||
/**
|
||
* capsule_console_birth - Birth a bare console VM.
|
||
*
|
||
* @param console_name Symbolic name for the new VM -- by convention
|
||
* the same name a user's own identity uses (e.g.
|
||
* "CaptBob"); sk_repl_dispatch_line() looks for a
|
||
* live "<name>~user" counterpart to decide
|
||
* whether a given active VM is a console.
|
||
* @param out_vm_id Output: assigned VM ID.
|
||
* @param out_vm_ctx Output: new VM context (may be NULL).
|
||
* @return CAPSULE_RUN_OK on success, error code otherwise.
|
||
*/
|
||
CapsuleRunResult capsule_console_birth(const char *console_name,
|
||
VMUuid *out_vm_id, void **out_vm_ctx);
|
||
|
||
#endif /* __STARKERNEL__ */
|
||
|
||
#endif /* STARKERNEL_CAPSULE_CONSOLE_H */
|